Skip to content

Conversation

@PavelKorobchuk
Copy link
Contributor

@PavelKorobchuk PavelKorobchuk commented Oct 1, 2025

Renamed all CIBA and Token Vault-related methods/classes in our AI JS SDK
According to name convention docs

Copy link
Contributor

@deepu105 deepu105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has a lot of unrelated and unnecessary changes. Can we please stick to just renaming the API calls and stuff

@priley86
Copy link
Contributor

priley86 commented Oct 3, 2025

This PR has a lot of unrelated and unnecessary changes. Can we please stick to just renaming the API calls and stuff

unfortunately, i think this change will soon require some of the langgraph + ai sdk 5 updates as well (w/ these core package updates coming). Preference here is to do at once, since these examples have not yet been updated, and so we do not have to re-test all of these twice / re-update the public documentation separately. We cut separate tags for those in the automated JS release, but i don't think we are planning to do this in the python. Agree it would have been cleaner git history here to isolate, but this is a bigger effort then.

These changes should not be overly significant though, and similar examples have been validated to work previously in the auth0-ai-js / auth0-ai-python repos though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file, sibling files and directory name should be identical to the contents of the packages/ai-components/templates/TokenVault/* directory from your PR at: auth0/auth0-ai-js#285

This repo seems to hold a old version of the component and is a bit confusing. For example, the FederatedConnectionInterruptHandler does not belong as part of this component and should be moved out.

This same comment applies to all other samples below in the PR 👇

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 here, was noting the same recently in auth0-assistant0 repo. We seem to have different variations of this component, so i would agree w/ moving it out to another directory that is more local to the usage for now.

examples:
https://github.com/auth0-samples/auth0-assistant0/blob/main/py-langchain/frontend/src/components/auth0-ai/FederatedConnections/FederatedConnectionsInterruptHandler.tsx

and:
https://github.com/auth0-samples/auth0-assistant0/blob/main/ts-vercel-ai/src/components/auth0-ai/federated-connections/index.tsx

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@priley86
Copy link
Contributor

Looking pretty good here! Lets be certain to delete all temporary packages/* / tempoary .tgz's now - those are no longer in use 😄

@priley86
Copy link
Contributor

priley86 commented Oct 16, 2025

suggestion here would be to:

  • apply latest main as merge commit: d785b83
  • apply minor code updates based on your review/tests this morning:
    0ed111b (made a mention about the authorization-for-rag/llamaindex-agentic-js example after our tests)
  • delete bun.lock d3cad9a

please help me validate those look ok 🙏

"clsx": "^2.1.1",
"date-fns": "^4.1.0",
"dotenv": "^17.0.1",
"dotenv": "^16.4.7",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(mental note): for clarity sake on this when we come back in future, it seems the only transitive dep still relying on dotenv@^16 was @langchain/community at this time (which leads to install warnings w/ ^17). We should be able to bump all other examples to latest dotenv though, and hopefully deprecate @langchain/community usage or upgrade it (if one is available later on).

error freshly generating package-lock w/ 17.0.1:

$ npm install --registry https://registry.npmjs.org/
npm error code ERESOLVE
npm error ERESOLVE unable to resolve dependency tree
npm error
npm error While resolving: [email protected]
npm error Found: [email protected]
npm error node_modules/dotenv
npm error   dotenv@"^17.0.1" from the root project
npm error
npm error Could not resolve dependency:
npm error peer dotenv@"^16.4.5" from @browserbasehq/[email protected]
npm error node_modules/@browserbasehq/stagehand
npm error   peer @browserbasehq/stagehand@"^1.0.0" from @langchain/[email protected]
npm error   node_modules/@langchain/community
npm error     @langchain/community@"^0.3.55" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error /Users/patrick.riley/.npm/_logs/2025-10-16T17_43_01_974Z-eresolve-report.txt
npm error A complete log of this run can be found in: /Users/patrick.riley/.npm/_logs/2025-10-16T17_43_01_974Z-debug-0.log

w/ 16.4.7:

$ npm install --registry https://registry.npmjs.org/
npm warn deprecated @esbuild-kit/[email protected]: Merged into tsx: https://tsx.is
npm warn deprecated @esbuild-kit/[email protected]: Merged into tsx: https://tsx.is
npm warn deprecated [email protected]: Use your platform's native DOMException instead

added 815 packages, and audited 816 packages in 28s

260 packages are looking for funding
  run `npm fund` for details

4 moderate severity vulnerabilities

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.
$ npm ls dotenv
[email protected] /Users/patrick.riley/github-public/auth0-ai-samples/call-apis-on-users-behalf/your-api/langchain-next-js
├─┬ @langchain/[email protected]
│ ├─┬ @browserbasehq/[email protected]
│ │ └── [email protected] deduped
│ └─┬ [email protected]
│   └── [email protected] deduped
└── [email protected]

@priley86
Copy link
Contributor

@deepu105 - awaiting your approve 🙏

Copy link
Contributor

@deepu105 deepu105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubber stamp

@priley86 priley86 merged commit bb8543e into auth0-samples:main Oct 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants